Custom Reproducibility Checklists , Attributes and their Unit testing. - #445
Merged
Conversation
…tes and their unit tests
lrasmus
requested changes
Aug 13, 2026
lrasmus
left a comment
Contributor
There was a problem hiding this comment.
I started reviewing the custom attribute and found something with the use of localStorage I wanted to report right away. I'll keep reviewing the rest of the code for the checklist items as you work on this.
lrasmus
requested changes
Aug 25, 2026
lrasmus
left a comment
Contributor
There was a problem hiding this comment.
Really, really great work! Very thorough in considering edge cases and security, and with your testing. I have a few items (several are really minor) for you to take a look at.
lrasmus
approved these changes
Sep 2, 2026
lrasmus
left a comment
Contributor
There was a problem hiding this comment.
This is wonderful, thank you so much @dibyanshu-pal-kushwaha!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproducibility checklists